Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the state of the lima container provider #2572

Merged
merged 2 commits into from
May 22, 2023

Conversation

afbjorklund
Copy link
Contributor

What does this PR do?

The connection status was always "unknown", so it was not listed as a container engine even if the lima provider was "started".

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

brew install lima
limactl start template://podman

The connection status was always "unknown", so it was not listed
as a container engine even if the lima provider was "started".

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
@afbjorklund afbjorklund requested review from a team and benoitf as code owners May 21, 2023 21:08
@afbjorklund afbjorklund requested review from jeffmaury and cdrage and removed request for a team May 21, 2023 21:08
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

image

image

@benoitf benoitf enabled auto-merge (rebase) May 22, 2023 08:16
Change-Id: I7c1d2b8be908c7b12f4e2b3d18dcd15aaf675a02
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf disabled auto-merge May 22, 2023 08:30
@benoitf benoitf enabled auto-merge (squash) May 22, 2023 08:31
@benoitf benoitf disabled auto-merge May 22, 2023 08:37
@benoitf benoitf merged commit cbc215c into containers:main May 22, 2023
6 of 7 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.1.0 milestone May 22, 2023
@benoitf benoitf modified the milestones: 1.1.0, 1.0.1 May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants