Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add meaningful tooltip for build, pull, prune image button #2602

Merged
merged 1 commit into from May 24, 2023

Conversation

fatelei
Copy link
Contributor

@fatelei fatelei commented May 23, 2023

What does this PR do?

Screenshot/screencast of this PR

Change tooltip for Prune images

image

Add tooltip for button Pull an image

image

Add tooltip for button Build an image

image

What issues does this PR fix or reference?

#2016

How to test this PR?

@fatelei fatelei requested review from a team and benoitf as code owners May 23, 2023 15:42
@fatelei fatelei requested review from jeffmaury and cdrage and removed request for a team May 23, 2023 15:42
@benoitf
Copy link
Collaborator

benoitf commented May 23, 2023

hello @fatelei and thanks for your contribution

you'll need to add Signed-Off to your commit
https://github.com/containers/podman-desktop/pull/2602/checks?check_run_id=13697422000

@benoitf
Copy link
Collaborator

benoitf commented May 23, 2023

FYI @fatelei there are formatting issues
[warn] packages/renderer/src/lib/engine/Prune.svelte
[warn] packages/renderer/src/lib/ImagesList.svelte

you need to run format:fix to fix the issue

If you don't, I can do it on top of your branch.

Signed-off-by: fatelei <fatelei@gmail.com>
auto-merge was automatically disabled May 24, 2023 01:04

Head branch was pushed to by a user without write access

@fatelei
Copy link
Contributor Author

fatelei commented May 24, 2023

FYI @fatelei there are formatting issues [warn] packages/renderer/src/lib/engine/Prune.svelte [warn] packages/renderer/src/lib/ImagesList.svelte

you need to run format:fix to fix the issue

If you don't, I can do it on top of your branch.

fixed

Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit 1605b6b into containers:main May 24, 2023
7 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.1.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants