chore: use publisher.extensionName as extension identifier instead of just the extension name #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
jeffmaury and
cdrage
and removed request for
a team
benoitf
force-pushed
the
fix-id
branch
2 times, most recently
from
0f1e501
to
060a6fa
Compare
avoid potential collision if it is just the name Change-Id: Ib872bb654e2961513f7367eff6dcb7e258b6d2e0 Signed-off-by: Florent Benoit <fbenoit@redhat.com> Change-Id: Ie018e0a0e210b8599c7b425dc877c9d308cf870d
benoitf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
avoid potential collision if it is just the name
migrate extension storage from old path to the new path
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Ensure ids are the identifier : publisherName.extensionName
How to test this PR?
Should work as before (like browsing extensions in settings page)
Change-Id: Ib872bb654e2961513f7367eff6dcb7e258b6d2e0