fix: Quick pick click to close and over nav bar #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two of the problems from issue containers#2754: - Clicking outside of the quick pick or input will close it (same behaviour as Esc). - Quick pick moved 'up' to same place as message box so that it is over top of the main nav bar. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
benoitf
reviewed
Jun 6, 2023
benoitf
approved these changes
Jun 6, 2023
Use outerDiv variable name since that's the area we want to detect changes outside of, and use correct HTMLDivElement type. Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
approved these changes
Jun 7, 2023
cdrage
approved these changes
Jun 8, 2023
cdrage
approved these changes
Jun 8, 2023
Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes two of the problems from issue #2754:
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fixes 2/3 of issue #2754.
How to test this PR?
Open a quickpick, confirm the nav bar is faded out and clicking outside closes it, but clicking inside still selects an item.