Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Minikube install docs #2824

Merged
merged 1 commit into from Jun 12, 2023

Conversation

afbjorklund
Copy link
Contributor

What does this PR do?

Adds installation instructions for the "minikube" extension, not in featured list

Screenshot/screencast of this PR

podman-desktop-install-minikube

What issues does this PR fix or reference?

How to test this PR?

cd website
yarn start

http://localhost:3000/docs/kubernetes/minikube

@afbjorklund afbjorklund requested review from a team, slemeur, themr0c and benoitf as code owners June 12, 2023 20:56
@afbjorklund afbjorklund requested review from jeffmaury and lstocchi and removed request for a team June 12, 2023 20:56
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
@afbjorklund
Copy link
Contributor Author

afbjorklund commented Jun 12, 2023

Apparently running the format check in "website" doesn't check anything ?

$ prettier --check "{extensions,packages,tests,types}/**/*.{ts,svelte}" "extensions/*/scripts/build.js" "website/**/*.{md,js}" "website/src/**/*.{css,tsx}"
$ prettier --check 'src/**/*.{css,ts,tsx}'

Missing the **/*.{md,js}

@benoitf benoitf enabled auto-merge (rebase) June 12, 2023 21:12
@benoitf
Copy link
Collaborator

benoitf commented Jun 12, 2023

@afbjorklund lint:fix in root directory and format:fix

Maybe we need to setup a precommit task

@benoitf benoitf merged commit 3cd71de into containers:main Jun 12, 2023
10 of 11 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.2.0 milestone Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants