Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Deleting a running pod generates an error #2827

Merged
merged 2 commits into from Jun 13, 2023

Conversation

jeffmaury
Copy link
Contributor

@jeffmaury jeffmaury commented Jun 13, 2023

Fixes #2413

What does this PR do?

Removes the error reported to the user when deleting a running pod

Screenshot/screencast of this PR

pods

What issues does this PR fix or reference?

Fixes #2413

How to test this PR?

  1. Create a Pod from a container
  2. Go to the Pods tab
  3. Delete the Pod

Fixes containers#2413

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested review from a team and benoitf as code owners June 13, 2023 07:45
@jeffmaury jeffmaury requested review from cdrage and lstocchi and removed request for a team June 13, 2023 07:45
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Win11, works fine. LGTM!! 🚀

@jeffmaury jeffmaury merged commit 470c8dd into containers:main Jun 13, 2023
8 checks passed
@jeffmaury jeffmaury deleted the GH-2413 branch June 13, 2023 15:23
@podman-desktop-bot podman-desktop-bot added this to the 1.2.0 milestone Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pods: deleting a running pod generates an error
4 participants