fix: Async telemetry startup #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user has enabled telemetry we currently block initialization until we are able to configure telemetry and send the first event out. I can't see any issues with just making this async; we already queue up pending events. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
benoitf
reviewed
Jun 15, 2023
| if (this.isTelemetryEnabled()) { | ||
| await this.configureTelemetry(); | ||
| this.configureTelemetry().catch((err: unknown) => { | ||
| console.log(`Error initializing telemetry: ${err}`); |
Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the user has enabled telemetry we currently block initialization until we are able to configure telemetry and send the first event out. This can delay startup unnecessarily if there are any DNS/network issues. I can't see any issues with just making this async; we already queue up pending events.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
None, see background in issue #1633.
How to test this PR?
No visible change/error during startup. You can add a delay in configureTelemetry() to tell the difference, or logging to confirm that events are still being sent.