fix: show current context in quick pick #2920
Conversation
Even when the quick pick is fixed to show which items are pre-selected (issue containers#2754 item 2) it is not really clear to the user why one row is highlighted. This adds the text " (current)" to the current Kube context to make this obvious. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
|
shouldn't we fix the quickpick component instead ? |
|
We should fix the quick pick too, but to me it's still not obvious why one item is selected by default. e.g. in the image if kind-kind-cluster-5 was selected I still need to think for a second to realize that's because it's the current context. I'm not sure how else to show this, especially for new users. |
|
@deboer-tim should we put the current item as the first item of the list ? |
|
I mean, the extension could always set as current value the one being selected (independent of the quickpick) |
| @@ -110,7 +110,7 @@ export async function updateContext( | |||
|
|
|||
| quickPicks = contexts.map(context => { | |||
| return { | |||
| label: context.name, | |||
| label: context.name === currentContext ? context.name + ' (current)' : context.name, | |||
There was a problem hiding this comment.
| label: context.name === currentContext ? context.name + ' (current)' : context.name, | |
| label: context.name === currentContext ? `${context.name} (current)` : context.name, |
|
I think the current context should be the one selected by default and VSCode OpenShift uses another styling:
|
Jeff's suggestion is better. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
Quickpicks can have a description?? 😀 Switched to use the same styling, using a current context description is better than changing the label: |
What does this PR do?
Even when the quick pick is fixed to show which items are pre-selected (issue #2754 item 2) it is not really clear to the user why one row is highlighted. This adds the text " (current)" to the current Kube context to make this obvious.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
N/A
How to test this PR?
Click on the context status bar to see the quick pick.