fix: compose deactivate function never called #2922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odockal
requested review from
jeffmaury and
cdrage
and removed request for
a team
benoitf
approved these changes
Jun 19, 2023
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
mairin
pushed a commit
to mairin/podman-desktop
that referenced
this pull request
Jun 25, 2023
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Makes sure that compose deactivate is called.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
#2921
How to test this PR?
yarn installyarn compilestart locally built podman desktop
watch the log in the output on the app. quit
expect to see a
stopping compose extensionmessage