Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto-scrolling on form pages, layout issues #2927

Merged
merged 2 commits into from Jun 19, 2023
Merged

fix: auto-scrolling on form pages, layout issues #2927

merged 2 commits into from Jun 19, 2023

Commits on Jun 19, 2023

  1. fix: auto-scrolling on form pages, layout issues 

    Fixing PR containers#2863 has exposed issues with all of the 'child form pages':
- build/pull/run image
- play kube
- deploy pod
- create pod from container

Prior to the change these pages were all reliant on scrolling to exist somewhere external and the
entire page would scroll. Although it often looked poor in some cases you could always get to the
content. Now that we have fixed page headers and no automatic scrolling, these pages need to
declare which div to autoscroll on.

While fixing this I found that two screens had prior scrolling/display issues, and controls
would appear 'outside' of the background panel or partially hidden offscreen. Although
they're not directly related it made sense to fix them here so that I could confirm the correct
scrolling behaviour:

DeployPodToKube - The h-1/3 was causing the height calculation to be wrong and the Deploy button
  was often hanging off the bottom of the panel. Use a fixed height for the editor instead.
PodCreateFromContainers - The minimum width would force unnecessary scrollbars when the window
  was narrow, and float-right left the Close and Create Pod buttons hanging off the bottom of
  the panel.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    8564894 View commit details
    Browse the repository at this point in the history

  2. fix: overflow-auto in NavPage 

    Moves overflow-auto 'up' to the NavPage so that all child content automatically
scrolls as necessary. Moved top of search bar padding to bottom of title - this
helps child pages without search so that there is a little padding under the
title (when scrolling the content doesn't look like it hits the title).

Most child content divs require 'min-w-full and h-fit' so that the form stays
full width but only as large vertically as necessary, made this consistent.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Jun 19, 2023
    Configuration menu
    Copy the full SHA
    f59c901 View commit details
    Browse the repository at this point in the history