fix: detailspage, resizing & consistency #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The four details pages each had a little uniqueness, and some copy/paste errors (e.g. issue containers#2986 - the close button goes to the wrong place). They also had layout issues when the window is narrower (issue 2322). This creates a common DetailsPage component to make sure the pages are consistent, and applies it to each page. There are two features that are only used by one page right now (e.g. images have a title detail in purple; containers has statistics detail on the right) but otherwise everything in the same. Fixed a few layout issues in the component to improve narrow layouts (e.g. extraneous spacing, moved tabs to new row) and fixed the close action. There is still some work that could be done to reduce some of the class attributes that are still required in each page or simplify further, but I think this is a good pass. Fixes containers#2322. Fixes containers#2986. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
lstocchi
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The four details pages each had a little uniqueness, and some copy/paste errors (e.g. issue #2986 - the close button goes to the wrong place). They also had layout issues when the window is narrower (issue #2322).
This creates a common DetailsPage component to make sure the pages are consistent, and applies it to each page. There are two features that are only used by one page right now (e.g. images have a title detail in purple; containers has statistics detail on the right) but otherwise everything in the same.
Fixed a few layout issues in the component to improve narrow layouts (e.g. extraneous spacing, moved tabs to new row) and fixed the close action. There is still some work that could be done to reduce some of the class attributes that are still required in each page or simplify further, but I think this is a good pass.
Screenshot/screencast of this PR
Before:
After:
What issues does this PR fix or reference?
Fixes #2322.
Fixes #2986.
How to test this PR?
Open up the details pages on each kind of object.