Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update nodejs version to 18 in .nvmrc to fix yarn install failure #2989

Merged
merged 2 commits into from Jun 26, 2023

Conversation

dgolovin
Copy link
Contributor

What does this PR do?

Fixing yarn install error:

eskimo@mac1 podman-desktop % nvm use 
Found '/Users/eskimo/Sources/podman-desktop/.nvmrc' with version <16>
Now using node v16.19.0 (npm v9.6.7)
eskimo@degolovi-mac podman-desktop % yarn install
yarn install v1.22.19
[1/5] 馃攳  Validating package.json...
[2/5] 馃攳  Resolving packages...
warning Resolution field "trim@0.0.3" is incompatible with requested version "trim@0.0.1"
[3/5] 馃殮  Fetching packages...
warning compose@0.0.1: The engine "podman-desktop" appears to be invalid.
warning docker@0.0.1: The engine "podman-desktop" appears to be invalid.
warning kind@0.0.1: The engine "podman-desktop" appears to be invalid.
warning kube-context@0.0.1: The engine "podman-desktop" appears to be invalid.
warning lima@0.0.1: The engine "podman-desktop" appears to be invalid.
warning podman@0.0.1: The engine "podman-desktop" appears to be invalid.
warning registries@0.0.1: The engine "podman-desktop" appears to be invalid.
error @octokit/graphql@6.0.1: The engine "node" is incompatible with this module. Expected version ">= 18". Got "16.19.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

N/A

How to test this PR?

Run commands below

1. cd podman-desktop
2. nvm use
3. yarn install

@dgolovin dgolovin requested review from a team and benoitf as code owners June 23, 2023 17:26
@dgolovin dgolovin requested review from jeffmaury and cdrage and removed request for a team June 23, 2023 17:26
@benoitf
Copy link
Collaborator

benoitf commented Jun 23, 2023

Issue is #2955
I think package.json should be updated as well

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dgolovin 馃帀 if you could fix the line in package.json as well

Signed-off-by: Denis Golovin <dgolovin@redhat.com>
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
@dgolovin dgolovin requested a review from benoitf June 26, 2023 19:24
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dgolovin

@dgolovin dgolovin merged commit 72df67f into containers:main Jun 26, 2023
10 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.2.0 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants