fix: website check targets #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afbjorklund
requested review from
a team,
slemeur,
themr0c and
benoitf
as code owners
afbjorklund
requested review from
jeffmaury and
lstocchi
and removed request for
a team
benoitf
requested changes
Jun 25, 2023
afbjorklund
force-pushed
the
website-check
branch
from
4b2bb8b
to
e187723
Compare
afbjorklund
changed the title
benoitf
reviewed
Jun 25, 2023
benoitf
reviewed
Jun 25, 2023
benoitf
reviewed
Jun 25, 2023
benoitf
requested changes
Jun 26, 2023
It was only possible to check the much bigger top-level targets... But it should be possible to format and lint also the website dir. Note: eslint resolve project includes from the current directory. So it'll look for website/website, workaround by running from root. Ideally it would be possible to use the current project directory, but that is only avaiable from eslintrc.js and not eslintrc.json Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
It was missing from the website package.json, even though it was checking the website directory. So should be there. The markdownlint-cli2 tool does **not** check in the parent directory, unlike the other tools, so add explicit config. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
prettier: node_modules/.cache/prettier eslint: .eslintcache Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
force-pushed
the
website-check
branch
from
e187723
to
1938c6e
Compare
$ yarn format:check && yarn lint:check
yarn run v1.22.19
$ prettier --cache --check '**/*.{md,js}' 'src/**/*.{css,ts,tsx}'
Checking formatting...
All matched files use Prettier code style!
Done in 2.84s.
yarn run v1.22.19
$ cd .. && eslint --cache --cache-location website/.eslintcache website --ext js,ts,tsx
Done in 5.16s.
$ yarn format:check && yarn lint:check
yarn run v1.22.19
$ prettier --cache --check '**/*.{md,js}' 'src/**/*.{css,ts,tsx}'
Checking formatting...
All matched files use Prettier code style!
Done in 0.60s.
yarn run v1.22.19
$ cd .. && eslint --cache --cache-location website/.eslintcache website --ext js,ts,tsx
Done in 1.42s. |
benoitf
approved these changes
Jun 27, 2023
|
tested and worked as expected, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It was only possible to check the much bigger top-level targets...
But it should be possible to format and lint also the website dir.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?
cd websiteyarn run