fix: keep stdout and stderr in the error object for Docker Desktop extensions #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
jeffmaury and
cdrage
and removed request for
a team
lstocchi
reviewed
Jun 27, 2023
jeffmaury
reviewed
Jun 28, 2023
benoitf
force-pushed
the
keep-stderr-stdout
branch
from
0439143
to
ba404f7
Compare
|
@jeffmaury should be fixed now |
jeffmaury
reviewed
Jun 28, 2023
cdrage
approved these changes
Jun 30, 2023
…ensions it looks like some extensions expect to find it Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…top extensions Signed-off-by: Florent Benoit <fbenoit@redhat.com>
…top extensions Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
force-pushed
the
keep-stderr-stdout
branch
from
ba404f7
to
10c7fc1
Compare
|
@jeffmaury looks like there was dead code. I removed the part about the .error field |
benoitf
changed the title
mairin
pushed a commit
to mairin/podman-desktop
that referenced
this pull request
Jul 7, 2023
…tensions (containers#3014) * fix: keep stdout ad stderr in the error object for Docker Desktop extensions Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Keep stdout ad stderr in the error object for Docker Desktop extensions
it looks like some extensions expect to find it
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fixes #3017
How to test this PR?