Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't show exception to user #3034

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Conversation

afbjorklund
Copy link
Contributor

What does this PR do?

There is already a nice explanation on why the detection failed, so no need to show an exception dialog about failing to start it.

Screenshot/screencast of this PR

Screenshot from 2023-06-27 17-31-44

What issues does this PR fix or reference?

How to test this PR?

On Linux: Don't install podman in the PATH, or only install podman-remote. Run Podman Desktop.

The error is posted in the console log, and the interface shows that podman could not be detected:

podman-missing
[podman] Failed to spawn process. Error: spawn podman ENOENT
    at ChildProcess._handle.onexit (node:internal/child_process:283:19)
    at onErrorNT (node:internal/child_process:476:16)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'spawn podman',
  path: 'podman',
  spawnargs: [ 'system', 'service', '--time=0' ]
}

Installing (and starting, preferrably!) Podman Engine needs to be done, before starting the application.

    sudo yum install -y podman

    systemctl --user enable podman.socket
    systemctl --user start podman.socket

    sudo loginctl enable-linger $USER

There is already a nice explanation on why the detection failed,
so no need to show an exception dialog about failing to start it.

	Uncaught Exception:
	Error: spawn podman ENOENT

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
@afbjorklund afbjorklund requested review from a team and benoitf as code owners June 27, 2023 19:55
@afbjorklund afbjorklund requested review from jeffmaury and lstocchi and removed request for a team June 27, 2023 19:55
@benoitf
Copy link
Collaborator

benoitf commented Jun 28, 2023

thanks @afbjorklund 🎉 , merging

@benoitf benoitf merged commit a2ca09b into containers:main Jun 28, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.2.0 milestone Jun 28, 2023
@afbjorklund afbjorklund deleted the spawn-enoent branch June 28, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants