Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change defaults for Podman machine #3061

Merged
merged 2 commits into from Jul 5, 2023
Merged

Conversation

jeffmaury
Copy link
Contributor

Fixes #3047

What does this PR do?

Changes the defaults when creating a new podman machine

Screenshot/screencast of this PR

What issues does this PR fix or reference?

Fixes #3047

How to test this PR?

Create a new Podman machine and see the results

Fixes containers#3047

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested review from a team and benoitf as code owners June 29, 2023 13:55
@jeffmaury jeffmaury requested review from cdrage and lstocchi and removed request for a team June 29, 2023 13:55
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know if documentation is impacted ?

@afbjorklund
Copy link
Contributor

You might want to consider having 4.000 GB as the default, instead of 4.096 GB ?

Another approach would be to use an even 4 GiB instead, that is: 4294967296 bytes.

"default": 4096000000,

@jeffmaury
Copy link
Contributor Author

You might want to consider having 4.000 GB as the default, instead of 4.096 GB ?

* [Size units wrongly processed #3062](https://github.com/containers/podman-desktop/issues/3062)

Another approach would be to use an even 4 GiB instead, that is: 4294967296 bytes.

"default": 4096000000,

I think as we display quantities as MB or GB, I think the default should be 2000000000 (changed to 4000000000)

@afbjorklund
Copy link
Contributor

afbjorklund commented Jun 30, 2023

I think as we display quantities as MB or GB, I think the default should be 2000000000 (changed to 4000000000)

As long as you have different defaults compared to podman machine CLI, that makes sense (simpler GUI sliders)

The scale factor needs to be change accordingly, so that it gets the right number of MiB to use (1907.3486328125).

The init default has 2147483648 bytes (2.000GiB), which is presented to the user by list as "2.147GB"

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury merged commit 1e337d9 into containers:main Jul 5, 2023
8 checks passed
@jeffmaury jeffmaury deleted the GH-3047 branch July 5, 2023 06:47
@podman-desktop-bot podman-desktop-bot added this to the 1.2.0 milestone Jul 5, 2023
mairin pushed a commit to mairin/podman-desktop that referenced this pull request Jul 7, 2023
* fix: change defaults for Podman machine

Fixes containers#3047

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default podman-machine creation (rootful, 2CPUs, 4GB RAM)
5 participants