New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: calculate machine socket path for linux #3070
Conversation
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Hey @afbjorklund thanks for the PR. Can you let me know the testing steps? Got a bit confused when making the remote virtual machine 🤣 if you don't mind, then I can review it further. |
It is part of an epic, so I don't think you can test it properly without more features But you can run Podman Desktop is still hard-coding the local socket location, when running on Linux. Note that podman will use
But the tunnel is still created, under
|
Podman is supposed to create the (QEMU) virtual machine for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for now on Linux we don't monitor the machines, so it's kind of dead code for now
It makes the actual enabling smaller, once the feature has been figured out. i.e. how to toggle between multiple podman sockets, on the same desktop
|
sure, no problem. I prefer small PRs |
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
What does this PR do?
Preparing for being able to use podman machine also on Linux, by avoiding hardcoding only mac/win
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?