fix: do not remove registries when podman extension is stopping #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
jeffmaury,
cdrage and
dgolovin
and removed request for
a team
jeffmaury
reviewed
Jul 7, 2023
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
Applying auto-merge |
dgolovin
approved these changes
Jul 7, 2023
| @@ -77,7 +77,8 @@ export class RegistrySetup { | |||
| // For each registry in the file that is not in the inMemory, add it | |||
| const toBeAdded = inFileRegistries.filter(fileRegistry => !this.localRegistries.has(fileRegistry.serverUrl)); | |||
| toBeAdded.forEach(registry => { | |||
| extensionContext.subscriptions.push(extensionApi.registry.registerRegistry(registry)); | |||
There was a problem hiding this comment.
That is how I temporary fixed it in my local codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
do not remove registries when podman extension is stopping
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
fixes #3135
How to test this PR?
Use the issue test case