Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: images with spaces in entrypoints or commands fail to start #3161

Merged
merged 1 commit into from Jul 11, 2023

Conversation

jeffmaury
Copy link
Contributor

Relates to #958

What does this PR do?

Fixes an error related to #958 when entrypoint or commands contains spaces

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

See #958

How to test this PR?

Try to create a container from the nginx image

Relates to containers#958

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
@jeffmaury jeffmaury requested review from a team and benoitf as code owners July 10, 2023 13:02
@jeffmaury jeffmaury requested review from cdrage and lstocchi and removed request for a team July 10, 2023 13:02
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeffmaury jeffmaury merged commit 5d30d76 into containers:main Jul 11, 2023
8 checks passed
@jeffmaury jeffmaury deleted the GH-958 branch July 11, 2023 08:34
@podman-desktop-bot podman-desktop-bot added this to the 1.2.0 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants