feat: switch more pages to formpage #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes almost all of the remaining pages to FormPages, using the existing icons that are used in the actions to open the form and the form button: - Build image - Pull image - Play Kube YAML - Create Pod from containers Adds a new 'actions' slot for the PullImage page's Manage registries button. Adds 'missing' pull image action to the button to match other pages. Makes Kube play icon resizable so that a larger form can be used in the header. Svelte has no API to test slots directly (see below), so a FormPageSpec component is added solely to be able to test that the icon/actions/content slots work correctly. The actions section is also tested by confirming the pull image registry button. testing-library/svelte-testing-library#48 https://stackoverflow.com/questions/60771586/testing-svelte-components-that-use-slots Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
cdrage
and removed request for
a team
deboer-tim
added a commit
to deboer-tim/desktop
that referenced
this pull request
Jul 10, 2023
Troubleshooting is the one remaining page (after PR containers#3162) that wasn't a FormPage. This switches it over, and does some minimal styling to keep it consistent with other pages. Also fixed some minor formatting issues to make the section headers and spacing consistent. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Mairin clarified the design - the header should essentially be two rows: - breadcrumb row with breadcrumb, page name, and close action - titlebar with actions on the right i.e. the top row is only for navigation, the second row gives the title and actions for the page. The only real impact is that the 'Manage repos' button on the Pull Image page will move from the top line to under the X. The same change is intended to be made to the DetailsPage, but we need to decide how to deal with the container CPU/memory use first. Signed-off-by: Tim deBoer <git@tdeboer.ca>
|
New commit changed location of the Manage Registries button as per clarification from Mairin: |
deboer-tim
added a commit
that referenced
this pull request
Jul 11, 2023
Troubleshooting is the one remaining page (after PR #3162) that wasn't a FormPage. This switches it over, and does some minimal styling to keep it consistent with other pages. Also fixed some minor formatting issues to make the section headers and spacing consistent. Signed-off-by: Tim deBoer <git@tdeboer.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes almost all of the remaining pages to FormPages, using the existing icons that are used in the actions to open the form and the form button:
Adds a new 'actions' slot for the PullImage page's Manage registries button. Adds 'missing' pull image action to the button to match other pages. Makes Kube play icon resizable so that a larger form can be used in the header.
Svelte has no API to test slots directly (see below), so a FormPageSpec component is added solely to be able to test that the icon/actions/content slots work correctly. The actions section is also tested by confirming the pull image registry button.
testing-library/svelte-testing-library#48 https://stackoverflow.com/questions/60771586/testing-svelte-components-that-use-slots
Screenshot/screencast of this PR
What issues does this PR fix or reference?
N/A, updated design.
How to test this PR?
Go to all four pages to confirm new/consistent design.