Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: consistent max width and padding in settings #3232

Merged
merged 1 commit into from Jul 17, 2023
Merged

fix: consistent max width and padding in settings #3232

merged 1 commit into from Jul 17, 2023

Commits on Jul 14, 2023

  1. fix: consistent max width and padding in settings 

    Currently, each settings page has different maximum width and alignment.

This fix makes them all consistent: full width on smaller screens, and when
the width gets over 905px (*) they are centred.

Had to fix the proxy page a little b/c it was using block elements that
don't expand correctly.

(*) Why 905px? This is the current sweet-spot where the Settings > Resources
page just has three columns. The built-in sizes don't quite work:
max-w-screen-md is too narrow and a couple pages like resources look
squished; max-w-screen-lg is really wide and simpler pages like proxy and
preferences are stretched.

Fixes containers#3230.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    12f183f View commit details
    Browse the repository at this point in the history