feat: add kube actions (generate kube) to compose group of containers #3253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
lstocchi
and removed request for
a team
cdrage
force-pushed
the
generate-kube
branch
5 times, most recently
from
da08714
to
bdcf7f3
Compare
### What does this PR do? * Adds "Generate Kube" to Compose actions * Adds "Kube" tab to Compose details ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#3105 ### How to test this PR? 1. Deploy a docker-compose example (https://raw.githubusercontent.com/kubernetes/kompose/main/examples/docker-compose.yaml) 2. Go to the container view in PD 3. Press on the compose group 4. View kube tab <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
|
PR has been rebased and ready for review 💯 |
|
FYI I have an empty Log tab (I know it's not directly related to this PR) cgOVbm9AwL.mp4this is my docker compose file |
|
@cdrage will you file an issue for the missing logs or I create the issue ? |
slemeur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add kube to compose actions
What does this PR do?
Screenshot/screencast of this PR
Screen.Recording.2023-07-18.at.12.54.53.PM.mov
What issues does this PR fix or reference?
Closes #3105
How to test this PR?
(https://raw.githubusercontent.com/kubernetes/kompose/main/examples/docker-compose.yaml)
Signed-off-by: Charlie Drage charlie@charliedrage.com