Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix loader not centered horizontally #3270

Merged
merged 3 commits into from Jul 21, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Jul 19, 2023

What does this PR do?

Copy of #3269 for 1.2.x version

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

How to test this PR?

see instructions from #3269

Signed-off-by: Florent Benoit fbenoit@redhat.com

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner July 19, 2023 15:34
@benoitf benoitf requested review from jeffmaury and cdrage and removed request for a team July 19, 2023 15:34
@benoitf
Copy link
Collaborator Author

benoitf commented Jul 20, 2023

@deboer-tim you wanted to change the content to get rid of patternfly

you want to do it as part of this PR or a follow-up PR ?

@deboer-tim
Copy link
Collaborator

I would just do the following. Do you want to commit or should I do a separate PR? Not sure how to 'take over'.

  <main class="flex flex-row w-screen h-screen justify-center">
    <div class="flex flex-col justify-center">
      <SealRocket />
      <h1 class="text-center text-xl">Initializing...</h1>
    </div>
  </main>

@benoitf
Copy link
Collaborator Author

benoitf commented Jul 20, 2023

@deboer-tim you can just add new commits on top of my branch, PR will be updated 👍

Signed-off-by: Tim deBoer <git@tdeboer.ca>
Co-authored-by: Florent BENOIT <fbenoit@redhat.com>
Signed-off-by: Tim deBoer <git@tdeboer.ca>
@benoitf benoitf enabled auto-merge (squash) July 21, 2023 12:08
@benoitf benoitf merged commit c426d00 into containers:main Jul 21, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants