feat: add "deploy to kubernetes" button for compose group #3295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
lstocchi
and removed request for
a team
|
I've checked with a docker engine, then as generateKub is not possible there is a silent error so like for containers if engine is not of type 'podman' we should not add this action l3G3O57LKK.mp4 |
cdrage
changed the title
You're right. I had forgotten to hide that action if Docker is detected, it should only show for Podman similar to the current container / pod actions. Updated the PR, it will appear hidden now for Docker! |
cdrage
force-pushed
the
deploy-to-kube
branch
5 times, most recently
from
6c58082
to
d90df20
Compare
|
PR has been rebased and ready for review 💯 |
benoitf
approved these changes
Jul 26, 2023
### What does this PR do? * Adds button to Deploy to Kubernetes for a Compose group * Utilizes DeployPodToKube same code, but added a "compose" type * Adds a new function for listSimpleContainersByLabel for an easier way to find containers by label that you only need the name / id of. ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#3104 ### How to test this PR? 1. Deploy a Docker Compose example 2. Click on the "hamburger" button to bring up the Deploy To Kubernetes button. 3. Deploy to Kubernetes and make sure it's deployed correctly. <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add "deploy to kubernetes" button for compose group
What does this PR do?
to find containers by label that you only need the name / id of.
Screenshot/screencast of this PR
Screen.Recording.2023-07-20.at.2.11.58.PM.mov
What issues does this PR fix or reference?
Closes #3104
How to test this PR?
button.
Signed-off-by: Charlie Drage charlie@charliedrage.com