New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add summary tab for compose #3317
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
lstocchi
and removed request for
a team
July 24, 2023 16:58
lstocchi
reviewed
Jul 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of comments.
lstocchi
approved these changes
Jul 25, 2023
benoitf
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### What does this PR do? * Adds the summary tab for compose which takes inspiration on how we summarize pod details. * Adds tests ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#3191 ### How to test this PR? <!-- Please explain steps to reproduce --> 1. Deploy an example compose yaml 2. Click on the group of containers 3. Click on summary tab Signed-off-by: Charlie Drage <charlie@charliedrage.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
summarize pod details.
Screenshot/screencast of this PR
Screen.Recording.2023-07-24.at.12.59.02.PM.mov
What issues does this PR fix or reference?
Closes #3191
How to test this PR?
Signed-off-by: Charlie Drage charlie@charliedrage.com
What does this PR do?
Screenshot/screencast of this PR
What issues does this PR fix or reference?
How to test this PR?