Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add summary tab for compose #3317

Merged
merged 1 commit into from Jul 26, 2023
Merged

Conversation

cdrage
Copy link
Contributor

@cdrage cdrage commented Jul 24, 2023

What does this PR do?

  • Adds the summary tab for compose which takes inspiration on how we
    summarize pod details.
  • Adds tests

Screenshot/screencast of this PR

Screen.Recording.2023-07-24.at.12.59.02.PM.mov

What issues does this PR fix or reference?

Closes #3191

How to test this PR?

  1. Deploy an example compose yaml
  2. Click on the group of containers
  3. Click on summary tab

Signed-off-by: Charlie Drage charlie@charliedrage.com

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

@cdrage cdrage requested review from a team and benoitf as code owners July 24, 2023 16:58
@cdrage cdrage requested review from jeffmaury and lstocchi and removed request for a team July 24, 2023 16:58
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of comments.

Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if we should sort containers by alphabetical names (and maybe the same in the compose view in containers list)

image

do we need a fixed font also so all sha-1 have the same width

@cdrage
Copy link
Contributor Author

cdrage commented Jul 26, 2023

Thank you @benoitf I've opened up the issue here: #3344

### What does this PR do?

* Adds the summary tab for compose which takes inspiration on how we
  summarize pod details.
* Adds tests

### Screenshot/screencast of this PR

<!-- Please include a screenshot or a screencast explaining what is doing this PR -->

### What issues does this PR fix or reference?

<!-- Please include any related issue from Podman Desktop repository (or from another issue tracker).
-->

Closes containers#3191

### How to test this PR?

<!-- Please explain steps to reproduce -->

1. Deploy an example compose yaml
2. Click on the group of containers
3. Click on summary tab

Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@cdrage cdrage merged commit ab3e66e into containers:main Jul 26, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compose: Details tab for group of containers.
4 participants