fix: troubleshooting still waiting after failure #3354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor fix - when the troubleshooting page 'Ping' or 'Grab containers' buttons fail to connect, they still say '...Waiting for response...' along with the error message. This just updates the text to say 'Failed' and updates the tests as well. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
cdrage and
lstocchi
and removed request for
a team
benoitf
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Minor fix - when the troubleshooting page 'Ping' or 'Grab containers' buttons fail to connect, they still say '...Waiting for response...' along with the error message. This just updates the text to say 'Failed' and updates the tests as well.
Screenshot/screencast of this PR
Before:
After:
What issues does this PR fix or reference?
N/A
How to test this PR?
I originally hit this because I had a hung podman machine and tested the fix against that. If you can't recreate a similar situation, in dev mode you can recreate by adding an appropriate 'throw Error()' as I did for the screenshots. :)