fix: only delete selected pods #3378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deboer-tim
requested review from
cdrage and
lstocchi
and removed request for
a team
|
I think once we have the component test we're good to merge |
|
@deboer-tim will you be able to add the tests ? |
|
I have a couple tests, but was having trouble cleaning up when running with existing test, will give it another shot. |
|
Found my local problem: the selection was being cached in the containerGroups store between tests. Updated branch to latest main and added tests. |
Adds two tests: - deleting a standalone container without deleting pods - deleting a pod without deleting a standalone container Signed-off-by: Tim deBoer <git@tdeboer.ca>
benoitf
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR #2979 caused an unfortunate regression - it is missing the filter to only delete selected pods.
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fixes #3374.
How to test this PR?
Create at least one pod and a container. Select just the container in the Containers list and delete it from the toolbar Delete action, making sure the pod doesn't get deleted as well.