fix: create /usr/local/bin directory if it does not exist on binary install #3425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrage
requested review from
jeffmaury and
lstocchi
and removed request for
a team
cdrage
force-pushed
the
install-fail-compose-mac
branch
from
c829af1
to
420d9a7
Compare
|
Thanks @lstocchi I've updated it with the correct if statement as well as added a test for Linux as well. Good catch! I totally missed that. |
cdrage
force-pushed
the
install-fail-compose-mac
branch
from
420d9a7
to
687a036
Compare
lstocchi
approved these changes
Aug 4, 2023
install ### What does this PR do? * On macOS and Linux we install the binary to /usr/local/bin. However, we do not check to see if it exists or create the directory if it it does not exist. * This PR updates the installBinaryToSystem function to check and create the bin directory * Added tests * No updates to user UI (this all happens behind the scenes) ### Screenshot/screencast of this PR <!-- Please include a screenshot or a screencast explaining what is doing this PR --> ### What issues does this PR fix or reference? <!-- Please include any related issue from Podman Desktop repository (or from another issue tracker). --> Closes containers#3309 ### How to test this PR? 1. Modify the `localBinDir` const to `/usr/local/bin/foobar` or a random test folder that's non-existant 2. "Install" Compose using the normal functionality 3. Check the directory that the binary has been installed. <!-- Please explain steps to reproduce --> Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
install-fail-compose-mac
branch
from
687a036
to
94e5ee6
Compare
|
Rebased + repushed due to #3437 . Now it passes. |
|
There is a "typo" in the summary and the commit message is weird (GitHub template?) /usr/bin/local -> /usr/local/bin |
benoitf
reviewed
Aug 7, 2023
benoitf
reviewed
Aug 7, 2023
benoitf
reviewed
Aug 7, 2023
benoitf
changed the title
jeffmaury
approved these changes
Aug 8, 2023
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
cdrage
force-pushed
the
install-fail-compose-mac
branch
from
94e5ee6
to
d628feb
Compare
|
Updated based on commands 💯 |
cdrage
changed the title
benoitf
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: create /usr/local/bin directory if it does not exist on binary install
What does this PR do?
we do not check to see if it exists or create the directory if it it
does not exist.
the bin directory
Screenshot/screencast of this PR
Screen.Recording.2023-08-03.at.1.50.02.PM.mov
What issues does this PR fix or reference?
Closes #3309
How to test this PR?
localBinDirconst to/usr/local/bin/foobaror a randomtest folder that's non-existant
Signed-off-by: Charlie Drage charlie@charliedrage.com