Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dd): add support for backend extensions of Docker Desktop #3435

Merged
merged 1 commit into from Aug 9, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 4, 2023

What does this PR do?

Add support for backend extensions of Docker Desktop

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fix #2397

How to test this PR?

Unit tests are there but it needs checks on different system like Windows

First, you need a valid 'docker-compose binary existing as extensions rely on compose stuff.

You can try tailscale but I found some bugs that I reported here https://github.com/tailscale/docker-extension/pulls
so instead of using the 'official image' you should try using quay.io/fbenoit/tailscale-docker-extension:20230731 (that includes the 2 PRs)

You could check if the extension reported in the issue works

Go to settings/Docker Desktop extensions and try to install digmaai/digma-docker-extension:0.6.52

fix containers#2397

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner August 4, 2023 12:17
@benoitf benoitf requested review from jeffmaury, lstocchi and cdrage and removed request for a team August 4, 2023 12:17
Copy link
Contributor

@cdrage cdrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was able to test it using the tailscale extension but ran into one of the two issues that you filed.

LGTM!

@cdrage cdrage merged commit 97239a7 into containers:main Aug 9, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow launching backend containers with Extension
3 participants