Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid dashboard displaying providers starting while they don't #3451

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 8, 2023

What does this PR do?

add index on each block to ensure svelte is not updating other components

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Fixes #2365

How to test this PR?

How to try ? : use the reproduction use-case of the issue.
Check first by commenting out the patch, then try with the patch.

Unfortunately I see no way to have component test to reproduce/etc the bug

add index on each block to ensure svelte is not updating other components
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner August 8, 2023 07:15
@benoitf benoitf requested review from jeffmaury and cdrage and removed request for a team August 8, 2023 07:15
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cdrage
Copy link
Contributor

cdrage commented Aug 8, 2023

I no longer see OpenShift local starting, so the issue has been fixed. LGTM!

@cdrage cdrage merged commit 147207a into containers:main Aug 8, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I run podman, dashboard also shows that OpenShift Local is starting
4 participants