fix: add back 'Done' text on the button #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin and
jeffmaury
and removed request for
a team
deboer-tim
approved these changes
Aug 10, 2023
|
@deboer-tim yes good catch, amended |
|
There is something wrong, I pushed the commit but PR is not updated/new change is not there |
benoitf
force-pushed
the
DESKTOP-3485
branch
2 times, most recently
from
32c7073
to
7263a36
Compare
|
ok looks like it was lagging on github side... |
fixes containers#3251 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
removed the |
Yes, it has been very laggy today when I pushed too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add back 'Done' text on the button
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #3485
How to test this PR?
unit test or try the usecase of the issue