fix: kube event error when switching context #3494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containers#3035 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
jeffmaury
requested review from
dgolovin and
cdrage
and removed request for
a team
benoitf
reviewed
Aug 11, 2023
There was a problem hiding this comment.
silent catching can be harder to debug when we want to get errors, so probably a nicer message (and maybe no stack trace) but probably do not report as console.error but as a warning
Also depending of 'known' errors we could say 'Kubernetes context switched but the cluster is not reachable, ignoring"
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
cdrage
approved these changes
Aug 15, 2023
benoitf
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3035
What does this PR do?
Removes the log message when Kube context is switched
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
#3035
How to test this PR?
Switch from one Kubernetes context to another and check the error message is not logged anymore