Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refresh component when field is updated #3525

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 14, 2023

What does this PR do?

component should be reactive

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

fixes #3524

How to test this PR?

unit test or check the usecase of the issue

fixes containers#3524
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner August 14, 2023 12:15
@benoitf benoitf requested review from dgolovin, cdrage and vzhukovs and removed request for a team August 14, 2023 12:15
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E flake? Code looks good.

@benoitf
Copy link
Collaborator Author

benoitf commented Aug 14, 2023

@deboer-tim yes it looks like the test is not robust. Relaunching it and it is now ✅

@benoitf benoitf merged commit 5277096 into containers:main Aug 14, 2023
8 checks passed
@benoitf benoitf deleted the DESKTOP-3524 branch August 14, 2023 12:54
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AuditMessageBox component doesn't refresh when audit result are updated
4 participants