Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset error message each time we pull image #3550

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 16, 2023

What does this PR do?

reset error message each time we pull image
so we don't see previous error message in case of success

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes #3498

How to test this PR?

Test usecase of the issue but there is also unit test

fixes containers#3498
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner August 16, 2023 11:27
@benoitf benoitf requested review from dgolovin and cdrage and removed request for a team August 16, 2023 11:27
Copy link
Collaborator

@deboer-tim deboer-tim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test.

@benoitf benoitf merged commit df2dc65 into containers:main Aug 16, 2023
8 checks passed
@benoitf benoitf deleted the DESKTOP-3498 branch August 16, 2023 15:55
@podman-desktop-bot podman-desktop-bot added this to the 1.3.0 milestone Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error message is not cleared out between pulling a nonexisting image and right one
3 participants