fix: removing a connection(podman machine) should redirect to previous page #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin and
cdrage
and removed request for
a team
…s page fixes containers#3572 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
deboer-tim
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
when we remove a podman machine, connectionInfo object becomes undefined, then it was leading to failure on the rendering side and it's breaking all the UI until a reload of the screen
Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #3572
How to test this PR?
Check use-case of issue or use unit test
Signed-off-by: Florent Benoit fbenoit@redhat.com