Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wrapper around IPC protocol #359

Merged
merged 1 commit into from Aug 1, 2022

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Jul 29, 2022

it allows to unwrap errors and not get all the time
Error invoking remote method: : rootCause

note: image-registry:registerRegistry has been removed as it was not consumed by a client

Required for #296

related issue in electron: electron/electron#24427

Change-Id: I1da39e5dc928cccddf263ee506cc62a5163f2188
Signed-off-by: Florent Benoit fbenoit@redhat.com

it allows to unwrap errors and not get all the time
Error invoking remote method: <name of the method>: rootCause

Change-Id: I1da39e5dc928cccddf263ee506cc62a5163f2188
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from vzhukovs as a code owner July 29, 2022 16:02
Copy link
Contributor

@vzhukovs vzhukovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with test exception thrown from main code. Error message displayed on the UI (used image pull button) 👍

@benoitf benoitf merged commit 9d1250f into containers:main Aug 1, 2022
@podman-desktop-bot podman-desktop-bot added this to the 0.0.6 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants