Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle null value in container command (#3620) #3625

Merged
merged 1 commit into from Aug 22, 2023

Conversation

lstocchi
Copy link
Contributor

What does this PR do?

It handles the null value in container command so that it doesn't throw an error, resulting in an empty container list

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

it resolves #3620

How to test this PR?

  1. create a container with an image having a null command (such as docker.io/ashael/pi:latest)

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested review from benoitf and a team as code owners August 22, 2023 09:54
@lstocchi lstocchi requested review from dgolovin and cdrage and removed request for a team August 22, 2023 09:54
@benoitf
Copy link
Collaborator

benoitf commented Aug 22, 2023

issue is only in main branch so no need to do 1.3.x bug fix release

@lstocchi lstocchi merged commit eaf4c08 into containers:main Aug 22, 2023
8 checks passed
@lstocchi lstocchi deleted the i3620 branch August 22, 2023 12:55
@podman-desktop-bot podman-desktop-bot added this to the 1.4.0 milestone Aug 22, 2023
mairin pushed a commit to mairin/podman-desktop that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Container list empty - error in engine Podman TypeError: Cannot read properties of null (reading '0')
3 participants