feat: add arm64 binaries for Windows #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related to containers#3443 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf
requested review from
dgolovin and
lstocchi
and removed request for
a team
Closed
lstocchi
reviewed
Aug 23, 2023
| - uses: actions/upload-artifact@v3.1.2 | ||
| with: | ||
| name: windows-exe-x64 | ||
| path: ./dist/podman-desktop*-next-x64.exe |
There was a problem hiding this comment.
Shouldn't it be ./dist/podman-desktop*-x64.exe without next as in the portable artifactName there is no next?
There was a problem hiding this comment.
I wanted to check with the PR
but on my end I have in dist folder
ls -l dist
-rw-r--r--@ 1 benoitf staff 7831 Aug 23 10:14 builder-debug.yml
-rw-r--r--@ 1 benoitf staff 1888 Aug 23 10:12 builder-effective-config.yaml
-rw-r--r--@ 1 benoitf staff 713 Aug 23 10:14 latest.yml
-rw-r--r--@ 1 benoitf staff 83757463 Aug 23 10:14 podman-desktop-1.4.0-next-arm64.exe
-rw-r--r--@ 1 benoitf staff 83930056 Aug 23 10:14 podman-desktop-1.4.0-next-setup-arm64.exe
-rw-r--r--@ 1 benoitf staff 88850 Aug 23 10:14 podman-desktop-1.4.0-next-setup-arm64.exe.blockmap
-rw-r--r--@ 1 benoitf staff 231126266 Aug 23 10:14 podman-desktop-1.4.0-next-setup-x64.exe
-rw-r--r--@ 1 benoitf staff 240231 Aug 23 10:14 podman-desktop-1.4.0-next-setup-x64.exe.blockmap
-rw-r--r--@ 1 benoitf staff 314515309 Aug 23 10:14 podman-desktop-1.4.0-next-setup.exe
-rw-r--r--@ 1 benoitf staff 327191 Aug 23 10:14 podman-desktop-1.4.0-next-setup.exe.blockmap
-rw-r--r--@ 1 benoitf staff 230953372 Aug 23 10:14 podman-desktop-1.4.0-next-x64.exe
-rw-r--r--@ 1 benoitf staff 314342680 Aug 23 10:14 podman-desktop-1.4.0-next.exe
so if I pickup ./dist/podman-desktop*-x64.exe it means it'll take both the installer and the portable file
There was a problem hiding this comment.
on PR side it looks OK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add arm64 binaries for Windows
include the arch in the filename
Screenshot/screencast of this PR
What issues does this PR fix or reference?
related to #3443
How to test this PR?
Execute binaries on arm64 and x84