Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include right airgap file for Windows and arm64 #3651

Merged
merged 1 commit into from Aug 24, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Aug 23, 2023

What does this PR do?

Include the correct image (arm64 based)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

related to #3443

How to test this PR?

build air gap images and non air gapped images

check installer of podman is inside and that the podman image is included as well

related to containers#3443

Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner August 23, 2023 15:36
@benoitf benoitf requested review from dgolovin and cdrage and removed request for a team August 23, 2023 15:36
Copy link
Contributor

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran local build on win-x64 with AIRGAP_DOWNLOAD set. All the required resources configured by this PR seems to be included.
LGTM.

@benoitf benoitf merged commit e231503 into containers:main Aug 24, 2023
8 checks passed
@podman-desktop-bot podman-desktop-bot added this to the 1.4.0 milestone Aug 24, 2023
@benoitf benoitf linked an issue Aug 24, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Arm build
3 participants