New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preflight checks for windows #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test it on a Windows VM (may be delayed until tomorrow)
if (this.ARCH === currentArch) { | ||
return this.createSuccessfulResult(); | ||
} else { | ||
return this.createFailureResult('WSL2 works only on x64 OS.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it would be possible to add links/pointers to the user explaining it with more details (could be another iteration)
like showing https://docs.microsoft.com/en-us/windows/wsl/install or stuff like that
Here what is unclear to me is that it seems WL 2 is working with ARM64 based on https://docs.microsoft.com/en-us/windows/wsl/install-manual#step-2---check-requirements-for-running-wsl-2
so here probably it doesn't work for Podman, but not for WSL2 (need to change the failure message ?)
return { successful: true }; | ||
} else { | ||
return this.createFailureResult( | ||
'To be able to run WSL2 you need Windows 10 Build 18362 or later. Please update your OS.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benoitf As for doc links, I add links, but they rendered as plain text. |
@evidolob there is already podman-desktop/packages/preload/src/index.ts Lines 513 to 515 in bc9a2bd
|
I'll try again when PR has produced the windows artifact |
Saying no on Install I always see the pre-flight checks as well there is no way to hide them b4OQmVisdK.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll address some enhancements in upcoming PR
good work @evidolob
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Change-Id: Ic4104e57b3e7fdea073f099bfc4fc36e6a36304e Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
Change-Id: I13335889c9a6da7b7f6a4d158273a3cdcb45c5c5 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
282045f
to
46d0f20
Compare
I've added the hide of checks at the end of the install step |
What does this PR do?
Add preflight check which executes before podman installation.
Screenshot/screencast of this PR
WSL2 not installed:
2022-08-03.16-04-11_Trim.mp4
All checks passed:
2022-08-03.16-23-23_Trim.mp4
What issues does this PR fix or reference?
Resolve #326
How to test this PR?
You need windows machine without podman, hyper-v, wsl2 installed. Run podman-desktop, on podman welcome page click on
Install
button.