feat(terminal): session to the terminal is reused #3725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
dgolovin and
cdrage
and removed request for
a team
benoitf
changed the title
benoitf
changed the title
lstocchi
approved these changes
Aug 31, 2023
benoitf
changed the title
fixes containers#502 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
persists the terminal's session to a store, so we can see again the terminal's connection when switching from tab to tab and we don't start a new session
also we reconnect in case of connection's failure or if we end the current connection
this PR needs to be merged first
for the tests of the terminal it sets
screenReaderModeso accessibility elements are added in the rendering.Screenshot/screencast of this PR
What issues does this PR fix or reference?
fixes #502
How to test this PR?
Go to the terminal's of a container, go to another tab and then come back to the terminal's tab
you should see the previous content and be able to continue
if you exit from the terminal (like using
exitor control+d you're automatically reconnected