feat: allow to embed existing component to onboarding (#3755) #3763
Conversation
Signed-off-by: lstocchi <lstocchi@redhat.com>
lstocchi
requested review from
dgolovin and
cdrage
and removed request for
a team
Signed-off-by: lstocchi <lstocchi@redhat.com>
| }); | ||
| </script> | ||
|
|
||
| {#if embeddedComponent === 'create' && providerInfo && configurationItems} |
There was a problem hiding this comment.
I think 100% we need to add documentation to this part as unlike the other micromark features this seems really hidden.
If a provider such as Red Hat Sandbox were to add create to their extension, they wouldn't be able to figure it out through package.json / as well as other "onboarding-related" documentation.
With this PR, we are requiring that the provider has a containerProviderConnection provided.
We also have a kubernetes-specific one as well? So it's two things were misssing documentation for.
I'm fine if we create an issue for this so we can make sure we document the update.
There was a problem hiding this comment.
Yes, I still didn't add any doc for the onboarding as i was waiting it to settle down a bit. Or i would have to rewrite it from scratch almost every PR as it changed a lot from the first implementation.
I should be close to have a working onboarding for podman (install -> set some setting -> create/start machine), then i'll work on #3633 which covers all aspects of how to create an onboarding (including the supported embedded components).
Regarding the kubernetes-specific one - not sure if i got what you're saying but the code support the kubernetesProviderConnectionCreation. So if we create a workflow for kind it should work fine.
packages/renderer/src/lib/preferences/PreferencesConnectionCreationRendering.svelte
Outdated
Show resolved
Hide resolved
packages/renderer/src/lib/onboarding/OnboardingEmbeddedComponent.svelte
Outdated
Show resolved
Hide resolved
packages/renderer/src/lib/onboarding/OnboardingEmbeddedComponent.svelte
Outdated
Show resolved
Hide resolved
Signed-off-by: lstocchi <lstocchi@redhat.com>
| hideCloseButton="{true}" /> | ||
| {:else} | ||
| <div aria-label="not supported warning" class="flex min-h-[500px] items-center justify-center"> | ||
| This provider does not support this mode |
There was a problem hiding this comment.
maybe add the component that is not found. It may help for troubleshooting.
⚠️ This extension does not provide a component of the type "{component}"
Signed-off-by: lstocchi <lstocchi@redhat.com>
What does this PR do?
This PR allows to embed an existing svelte component to the onboarding. So far only the
createcomponent is allowed.Screenshot/screencast of this PR
What issues does this PR fix or reference?
it fixes #3755
How to test this PR?