fix: some containers never return logs, do not wait for them #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Golovin <dgolovin@redhat.com>
dgolovin
requested review from
jeffmaury and
cdrage
and removed request for
a team
benoitf
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
List of containers in pod can be returned in any order. When first container in list does not have log, waiting for logsContainer() call blocks the container list iteration and control never gets to container with log. This pr removes await for containerRegistry.logsContainer() call to avoid waiting forever for container without logs.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fix #3375.
How to test this PR?