Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove cancel button when on final onboarding step (#3771) #3802

Merged
merged 1 commit into from Sep 7, 2023

Conversation

lstocchi
Copy link
Contributor

@lstocchi lstocchi commented Sep 6, 2023

What does this PR do?

This PR removes the cancel button on the final step that represent the completed onboarding state. Once at the end, it does not make sense to show the cancel button.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

it fixes #3771

How to test this PR?

  1. run the onboarding and check there is no cancel button in the final step

)

Signed-off-by: lstocchi <lstocchi@redhat.com>
@lstocchi lstocchi requested review from benoitf and a team as code owners September 6, 2023 15:48
@lstocchi lstocchi requested review from dgolovin and jeffmaury and removed request for a team September 6, 2023 15:48
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just a side note, as the workflow is gone to end, shouldn't we see Finish instead of Next ?

@lstocchi
Copy link
Contributor Author

lstocchi commented Sep 7, 2023

Just a side note, as the workflow is gone to end, shouldn't we see Finish instead of Next ?

Question for @mairin.
BTW i agree, it makes sense. I'll ask her and gonna create a follow-up PR 👍

@lstocchi lstocchi merged commit 55203e4 into containers:main Sep 7, 2023
8 checks passed
@lstocchi lstocchi deleted the i3771 branch September 7, 2023 07:24
@podman-desktop-bot podman-desktop-bot added this to the 1.4.0 milestone Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not show cancel button in the final step of the onboarding
3 participants