fix: mounts can be null when using older podman #3806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
requested review from
dgolovin and
jeffmaury
and removed request for
a team
benoitf
reviewed
Sep 6, 2023
There was a problem hiding this comment.
@afbjorklund could you add a test so we're sure it won't happen again ?
Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
benoitf
approved these changes
Sep 7, 2023
|
thanks @afbjorklund |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Older versions of podman has Mounts: null, so the feature of listing containers using a volume does not work.
But it is better to leave that extra information out from the volume list, than to throw an error during
findScreenshot/screencast of this PR
What issues does this PR fix or reference?
Closes #3804
How to test this PR?