fix: pass the copy of object to avoid modifying an original one #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
reviewed
Aug 8, 2022
| @@ -107,6 +107,6 @@ function toggleRegistryModal(): void { | |||
| <PreferencesRegistriesEditCreateRegistryModal | |||
| toggleCallback="{toggleRegistryModal}" | |||
| mode="{preferencesMode}" | |||
| registry="{selectedRegistry}" /> | |||
| registry="{{source: selectedRegistry?.source, serverUrl: selectedRegistry?.serverUrl, username: selectedRegistry?.username, secret: selectedRegistry?.secret}}" /> | |||
There was a problem hiding this comment.
will it work to use {...selectedRegistry} ?
There was a problem hiding this comment.
approving but better if we can use spread syntax as we don't need to enumerate all fields
There was a problem hiding this comment.
yep, that works, updated the PR
vzhukovs
force-pushed
the
dialog-options
branch
from
1afb36f
to
5a74fa1
Compare
benoitf
approved these changes
Aug 8, 2022
vzhukovs
force-pushed
the
dialog-options
branch
from
2893b8d
to
df837ea
Compare
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
vzhukovs
force-pushed
the
dialog-options
branch
from
ba7d5eb
to
643d45e
Compare
benoitf
changed the title
benoitf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Do not modify the original registry object instance, when the dialog opens. This prevents the original object instance from the modification, when user closes the dialog without create or update action.
Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
part of #290
How to test this PR?
Open dialog to modify the existed registry, type any values and close the dialog, then open the dialog again. Values should not be modified.