fix: set proxy env variable when launching process #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes containers#3768 Signed-off-by: Jeff MAURY <jmaury@redhat.com>
jeffmaury
requested review from
dgolovin and
lstocchi
and removed request for
a team
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
benoitf
reviewed
Sep 8, 2023
Comment on lines
34
to
45
| if (proxy.isEnabled()) { | ||
| if (proxy.proxy?.httpsProxy) { | ||
| env.HTTPS_PROXY = 'http://' + proxy.proxy.httpsProxy; | ||
| } | ||
| if (proxy.proxy?.httpProxy) { | ||
| env.HTTP_PROXY = 'http://' + proxy.proxy.httpProxy; | ||
| } | ||
| if (proxy.proxy?.noProxy) { | ||
| env.NO_PROXY = proxy.proxy.noProxy; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
it means that if extension is setting a proxy data, it'll be replaced all the times by Podman Desktop ?
There was a problem hiding this comment.
Yes I don't see the use case
benoitf
reviewed
Sep 8, 2023
Signed-off-by: Jeff MAURY <jmaury@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3768
What does this PR do?
Set the proxy environment variables when launching process using the extension API
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Fixes #3768
How to test this PR?