Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to click enter in pull image name input #3850

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Conversation

deboer-tim
Copy link
Collaborator

@deboer-tim deboer-tim commented Sep 8, 2023

What does this PR do?

Allows users to hit Enter after typing in an image name in the Pull Image form. Minor usability improvement, just saves grabbing the mouse to click the Pull Image button.

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Fixes #3849.

How to test this PR?

Go to pull an image and hit Enter after typing the name instead of clicking on the button.

Allows users to hit Enter after typing in an image name in the Pull Image
form. Minor usability improvement, just saves grabbing the mouse to click
the Pull Image button.

Fixes issue #3849.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
@deboer-tim deboer-tim requested review from benoitf and a team as code owners September 8, 2023 20:56
@deboer-tim deboer-tim requested review from jeffmaury and lstocchi and removed request for a team September 8, 2023 20:56
Copy link
Contributor

@jeffmaury jeffmaury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dgolovin dgolovin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works.

@deboer-tim deboer-tim merged commit e79f9a2 into main Sep 11, 2023
8 checks passed
@deboer-tim deboer-tim deleted the pull-enter branch September 11, 2023 18:37
@podman-desktop-bot podman-desktop-bot added this to the 1.4.0 milestone Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be able to hit Enter when pulling image
4 participants