Don't log console errors when activating lima extension #3852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lima instance might not be running. This is not an error, so log it as debug. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
Only check socket files for container providers. Only check config files for kubernetes provider. Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
afbjorklund
requested review from
dgolovin and
cdrage
and removed request for
a team
afbjorklund
changed the title
benoitf
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Avoid logging errors for the lima extension.
Only check files in use, and use "debug" log.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Closes #3780
How to test this PR?
When not using the lima extension, log should be empty.
When using template://podman, no "kubernetes.sock" errors.