fix: don't prefix all podman machine names #3878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My initial position was that we shouldn't prefix any Podman machine names, but I've softened a bit: if someone appends to the default name and calls their machine "podman-machine-3", then I think it's nice we pretty-print that to "Podman Machine 3". But if I call my machine "My Machine", and that's the name I see on the command line, then I still believe we should use "My Machine" and not "Podman Machine My Machine". I have been using this change for a few days, and I prefer it. The only place I've found where there isn't the obvious context of My Machine being a Podman machine is in the system tray, and IMHO that's not a problem because I named it and recognize what it is in that context. Fixes #3424. Signed-off-by: Tim deBoer <git@tdeboer.ca>
deboer-tim
requested review from
jeffmaury and
cdrage
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
My initial position was that we shouldn't prefix any Podman machine names, but I've softened a bit: if someone appends to the default name and calls their machine "podman-machine-3", then I think it's nice we pretty-print that to "Podman Machine 3". But if I call my machine "My Machine", and that's the name I see on the command line, then I still believe we should use "My Machine" and not "Podman Machine My Machine".
I have been using this change for a few days, and I prefer it. The only place I've found where there isn't the obvious context of My Machine being a Podman machine is in the system tray, and IMHO that's not a problem because I named it and recognize what it is in that context.
Screenshot/screencast of this PR
What issues does this PR fix or reference?
Fixes #3424.
How to test this PR?
Create a new Podman machine without the prefix.